Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/minifier): Handle more indexing expression #8750

Merged
merged 80 commits into from
Jul 2, 2024
Merged

feat(es/minifier): Handle more indexing expression #8750

merged 80 commits into from
Jul 2, 2024

Commits on Jun 24, 2024

  1. Initial commit: string literals

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e926076 View commit details
    Browse the repository at this point in the history

  2. WIP: array literals

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e7122e1 View commit details
    Browse the repository at this point in the history

  3. Correctly handle array indexing

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    aaecdda View commit details
    Browse the repository at this point in the history

  4. Update unit test

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    6c990d1 View commit details
    Browse the repository at this point in the history

  5. Fix broken index logic

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    0544208 View commit details
    Browse the repository at this point in the history

  6. Fix indexing ObjectLits

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    dd4a564 View commit details
    Browse the repository at this point in the history

  7. Remove fraction check from LiteralVisitor

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7916e48 View commit details
    Browse the repository at this point in the history

  8. cargo fmt

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2075a25 View commit details
    Browse the repository at this point in the history

  9. Update test files

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    07f427d View commit details
    Browse the repository at this point in the history

  10. Handle x['0']

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    ee8f34b View commit details
    Browse the repository at this point in the history

  11. Don't return KnownOp::Len if obj is an ObjectLiteral

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7cfc984 View commit details
    Browse the repository at this point in the history

  12. Handle x['length']

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    25fcd45 View commit details
    Browse the repository at this point in the history

  13. Correctly handle builtin properties

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    ca089fb View commit details
    Browse the repository at this point in the history

  14. Don't replace ArrayLiteral if doing so may have side effects

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    823ed75 View commit details
    Browse the repository at this point in the history

  15. Update unit test

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    0c8386e View commit details
    Browse the repository at this point in the history

  16. Update minifier test files

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    4b4d8ad View commit details
    Browse the repository at this point in the history

  17. cargo fmt

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a0997fb View commit details
    Browse the repository at this point in the history

  18. Minifier shouldn't handle potential pristine_globals cases

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c2cd898 View commit details
    Browse the repository at this point in the history

  19. cargo fmt

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    da150a2 View commit details
    Browse the repository at this point in the history

  20. Update test files

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e7f6670 View commit details
    Browse the repository at this point in the history

  21. Don't add a dummy value if no side effects exist

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c1a13e2 View commit details
    Browse the repository at this point in the history

  22. Update test files

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e50ab82 View commit details
    Browse the repository at this point in the history

  23. Oops

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    3f86a8f View commit details
    Browse the repository at this point in the history

  24. Update unit test 

    The previous commit makes the whole array get replaced by just `f()`, which is correct, but we need a better case now
    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    82c02aa View commit details
    Browse the repository at this point in the history

  25. Add test case for side effects

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a4a08e2 View commit details
    Browse the repository at this point in the history

  26. Add compression for MemberExpr

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    19bf289 View commit details
    Browse the repository at this point in the history

  27. cargo fmt

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d96c998 View commit details
    Browse the repository at this point in the history

  28. String does not appear to inherit Function

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    3acffd1 View commit details
    Browse the repository at this point in the history

  29. Array also does not inherit Function

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    01d5b38 View commit details
    Browse the repository at this point in the history

  30. Remove comment

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    42bc03b View commit details
    Browse the repository at this point in the history

  31. FUNCTION_SYMBOLS is no longer required

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    15b42f1 View commit details
    Browse the repository at this point in the history

  32. Add unit test files

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    f59430d View commit details
    Browse the repository at this point in the history

  33. Update test files

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    13c0eed View commit details
    Browse the repository at this point in the history

  34. Update test config

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    9d1864e View commit details
    Browse the repository at this point in the history

  35. Better test dir names

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    f7e608b View commit details
    Browse the repository at this point in the history

  36. Remove evil clone

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    0268ff6 View commit details
    Browse the repository at this point in the history

  37. I don't know why this changed, but it did.

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    8d5ae30 View commit details
    Browse the repository at this point in the history

  38. Add array side effect unit test

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    af09c01 View commit details
    Browse the repository at this point in the history

  39. Don't optimize if inside left-hand side of AssignExpr

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    167e671 View commit details
    Browse the repository at this point in the history

  40. Remove redundant import

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    194249e View commit details
    Browse the repository at this point in the history

  41. Move call to end

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    f82d615 View commit details
    Browse the repository at this point in the history

  42. Cleanup iterator call

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    9bbedee View commit details
    Browse the repository at this point in the history

  43. Handle side effects and __proto__ in object compression

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    8a9e2cf View commit details
    Browse the repository at this point in the history

  44. Remove redundant return statement

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    f462bfc View commit details
    Browse the repository at this point in the history

  45. cargo fmt

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    3d0f354 View commit details
    Browse the repository at this point in the history

  46. Remove redundant Box::new call

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7469da7 View commit details
    Browse the repository at this point in the history

  47. Use preserve_effects

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    eb0c7ee View commit details
    Browse the repository at this point in the history

  48. cargo fmt

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    02032cc View commit details
    Browse the repository at this point in the history

  49. Exclude watch and unwatch

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    82e4b3e View commit details
    Browse the repository at this point in the history

  50. UPDATE=1 cargo test --test projects --test tsc

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    5ee31d3 View commit details
    Browse the repository at this point in the history

  51. UPDATE=1 cargo test -p swc_ecma_minifier --features concurrent

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d6fa0e7 View commit details
    Browse the repository at this point in the history

  52. Remove redundant import

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a691c25 View commit details
    Browse the repository at this point in the history

  53. Fix test_fold_array_lit_spread_get_elem

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    f3a2ff0 View commit details
    Browse the repository at this point in the history

  54. Fix test_fold_get_elem1

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c2f2e1f View commit details
    Browse the repository at this point in the history

  55. Add self.changed = true;

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    570bb69 View commit details
    Browse the repository at this point in the history

  56. Use ctx

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    38960d6 View commit details
    Browse the repository at this point in the history

  57. Fix doc

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    9eb723f View commit details
    Browse the repository at this point in the history

  58. Handle SeqExpr in optimize_member_expr

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    9be7be7 View commit details
    Browse the repository at this point in the history

  59. Remove dup self.changed = true;

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    94d9db5 View commit details
    Browse the repository at this point in the history

  60. Apply clippy suggestions

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    65ceb8d View commit details
    Browse the repository at this point in the history

  61. Cleanup optimize_member_expr 

    This fixes unit tests being stuck running for 60s+
    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    fc27b52 View commit details
    Browse the repository at this point in the history

  62. Fix optimization tests

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    95a1784 View commit details
    Browse the repository at this point in the history

  63. Fix optimization with OptCall

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e872c02 View commit details
    Browse the repository at this point in the history

  64. Move code into its own eval function

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    68a4bb9 View commit details
    Browse the repository at this point in the history

  65. Fix error

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2e96ce6 View commit details
    Browse the repository at this point in the history

  66. Remove redundant imports

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a7f8c7d View commit details
    Browse the repository at this point in the history

  67. Optimize imports

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    3e10aa6 View commit details
    Browse the repository at this point in the history

  68. Update parserForStatement9.2.minified.js

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    84dab43 View commit details
    Browse the repository at this point in the history

  69. Cleanup simplify

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d910b1a View commit details
    Browse the repository at this point in the history

  70. Handle __proto__ object when indexing known object keys

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    cefb0c0 View commit details
    Browse the repository at this point in the history

  71. cargo fmt

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7c7836e View commit details
    Browse the repository at this point in the history

  72. Remove is_opt_call

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    6bc56e9 View commit details
    Browse the repository at this point in the history

  73. Manually fix some files

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    cc0eabe View commit details
    Browse the repository at this point in the history

  74. Manually fix swc_ecma_minifier/Cargo.toml

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b88a29d View commit details
    Browse the repository at this point in the history

  75. Update call to nth_char

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    98f4eba View commit details
    Browse the repository at this point in the history

  76. Fix remaining undefined calls

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    fb62635 View commit details
    Browse the repository at this point in the history

  77. Update unit test file

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    af081f2 View commit details
    Browse the repository at this point in the history

  78. Update unit test files

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    f5a12fd View commit details
    Browse the repository at this point in the history

  79. Add report_change call

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    25fad28 View commit details
    Browse the repository at this point in the history

  80. test_issue8747 -> test_issue_8747

    @levi-nz
    levi-nz committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    6db7b18 View commit details
    Browse the repository at this point in the history