Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(es): Use Into and From for AST construction #9201

Merged
merged 33 commits into from
Jul 11, 2024
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 11, 2024

Description:

This PR will help modifying boxedness of AST nodes.

@kdy1 kdy1 added this to the Planned milestone Jul 11, 2024
@kdy1 kdy1 self-assigned this Jul 11, 2024
@kdy1 kdy1 changed the base branch from main to perf July 11, 2024 07:13
@kdy1 kdy1 marked this pull request as ready for review July 11, 2024 07:24
@kdy1 kdy1 requested review from a team as code owners July 11, 2024 07:24
@kdy1 kdy1 merged commit 28b6369 into swc-project:perf Jul 11, 2024
144 of 149 checks passed
@kdy1 kdy1 deleted the ast branch July 11, 2024 08:26
Copy link

codspeed-hq bot commented Jul 11, 2024

CodSpeed Performance Report

Merging #9201 will degrade performances by 4.01%

Comparing kdy1:ast (6e220fa) with kdy1:ast (71d8260)

Summary

❌ 3 regressions
✅ 170 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark kdy1:ast kdy1:ast Change
es/full/minify/libraries/lodash 274.1 ms 283.8 ms -3.41%
es/minifier/libs/lodash 241.7 ms 249.7 ms -3.21%
es/minifier/libs/vue 263.8 ms 274.8 ms -4.01%

kdy1 added a commit that referenced this pull request Jul 12, 2024
**Description:**

This PR will help modifying boxedness of AST nodes.
kdy1 added a commit that referenced this pull request Jul 12, 2024
**Description:**

This PR will help modifying boxedness of AST nodes.
@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 17, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant