Adding figure with lesson goal/overview

[vcheplygina]

Instructions

As discussed with @maxim-belkin, added overview figure and clarified the text a bit to add more context to the lesson.

[ldko]

I think the image adds a nice and informative overview of the lesson story and the text change makes things a bit clearer. I commented on a couple of minor technical details. What do you think @maxim-belkin ? Thanks very much for the addition, @vcheplygina !

[vcheplygina]

Thanks, good to hear! I tried to fix both in 7a81324 and 96673a6, I hope this is working as intended

[ldko]

Hi @vcheplygina I appreciate your modifying the image per my request. I checked with co-maintainer @maxim-belkin wondering about the pptx format. While a raw file is good to include, he indicated that pptx is not ideal because it is actually a zip archive. If possible, including an svg would be wonderful, and he recommended ImageMagick for that. One other wish list item from him was spacing the vertical alignment on the rows of numbers to more closely align with the patient icons. Let me know what you think about these requests--we are happy to have you working on this! Thank you!

[vcheplygina]

I've fixed the lines now hopefully. For the image, it was meant to be a sketch and the only way I know how to create diagrams, I certainly wouldn't mind somebody replacing it with a more visually and technically pleasing version.

[ldko]

Thanks, @vcheplygina! I understand about the diagram. I have not created an svg from scratch myself. :)

@maxim-belkin @annefou , I am happy with these changes. If we drop the pptx file, does it sound alright to you all to merge these changes, and if someone later wants to do any work on the image, they could use the png as a guide and recreate and edit it as an svg?

[maxim-belkin]

If we drop the pptx file, does it sound alright to you all to merge these changes, and if someone later wants to do any work on the image, they could use the png as a guide and recreate and edit it as an svg?

Yes, let's drop pptx and add alt. text before merging. This PR would have to be squash-merged (so that we don't bring in pptx from Veronika's branch).

Thank you, @vcheplygina, for your contribution!
And, of course, thank you, @ldko for taking care of this PR!

[maxim-belkin]

Veronika, apologies for taking so long to get to this. I've updated the figure. We (@ldko, @annefou and myself) discussed it briefly and it looks like we all like it. We still need an alt text for it but we can address it in a separate PR. Once this PR is merged, I'll push an updated gh-pages branch to your fork to keep it in a pristine state.

Thank you very much for your contribution to the lesson!

[maxim-belkin]

Veronika, a quick update: GitHub rejected my attempt to update the gh-pages branch in your fork after the PR was merged. Here's what you need to do to sync your gh-pages branch with the one in this repo:

# navigate to the folder containing this lesson on your computer
git checkout gh-pages
git fetch https://github.com/swcarpentry/python-novice-inflammation
git reset --hard FETCH_HEAD

[vcheplygina]

I fixed that now, thanks a lot! Happy to contribute :) The new figure looks great!

…

On Sat, Jan 30, 2021 at 12:40 AM Maxim Belkin ***@***.***> wrote: Veronika, a quick update: GitHub rejected my attempt to update the gh-pages branch in your fork after the PR was merged. Here's what you need to do to sync your gh-pages branch with the one in this repo: # navigate to the folder containing this lesson on your computer git checkout gh-pages git fetch https://github.com/swcarpentry/python-novice-inflammation git reset --hard FETCH_HEAD — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#891 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACQYF4THOZYCBQHUSYYT6RLS4NBQBANCNFSM4UASHAVA> .

[ldko]

Thanks @vcheplygina for proposing the new overview image and for clarifying the intro text. @maxim-belkin thanks for tidying up the image as an svg and getting things merged. I think the page looks great :).