Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use two-digit identifier for generated figures #166

Closed
gvwilson opened this issue Jul 6, 2016 · 7 comments
Closed

Use two-digit identifier for generated figures #166

gvwilson opened this issue Jul 6, 2016 · 7 comments

Comments

@gvwilson
Copy link
Contributor

gvwilson commented Jul 6, 2016

@fmichonneau writes:

For the fig path, I think it has been inconsistent. Personally, I
think it's a good idea to given figures a prefix for each episode, so
we can see right away where the figures are coming from (and whether
some need to be deleted if they are not in use anymore). Therefore, in
the gapminder lesson, I set as a prefix the 2 digit number for the
episode (even if the lesson doesn't generate a figure), so each
episode should start with something like:

    ```{r, include=FALSE}
    source("../bin/chunk-options.R")
    knitr_fig_path("01-")
    ```
  1. Make this change to all .Rmd files.
  2. Clean out all old figures.

See also swcarpentry/r-novice-inflammation#217

@fmichonneau
Copy link
Contributor

Just to clarify, as it stands, all Rmd files in _episodes_rmd for this lesson already have their fig path set this way, and I think that I removed all the figures that are not in use (but this should be double checked).

@gvwilson
Copy link
Contributor Author

gvwilson commented Jul 6, 2016

make lesson-check in the root directory warns me about two R files in
the fig directory:

Unexpected image files: 13-dplyr-generate-figures.R, 
14-tidyr-generate-figures.R

@fmichonneau
Copy link
Contributor

I'll also try to write the blog post about the details of using Rmd files with the new template today or Friday.

@gvwilson
Copy link
Contributor Author

gvwilson commented Jul 6, 2016 via email

@chendaniely
Copy link

has this issue been resolved?

I see the following when I look at ls *

fig:
01-supp-csv-without-row-nums.png  python-call-stack-07.svg                               rmd-02-func-R-rescale-test-2.png      rmd-03-loops-R-loop-analyze-3.png             rmd-04-cond-conditional-challenge-hist-3.png  rmd-12-supp-factors-reordering-factors-1.png
01-supp-csv-with-row-nums.png     python-flowchart-conditional.svg                       rmd-03-loops-R-inflammation-01-1.png  rmd-03-loops-R-loop-analyze-4.png             rmd-04-cond-inflammation-01-1.png             rmd-12-supp-factors-updating-factors-1.png
01-supp-csv-with-special-NA.png   python-sticky-note-variables-01.svg                    rmd-03-loops-R-inflammation-01-2.png  rmd-03-loops-R-loop-analyze-5.png             rmd-04-cond-inflammation-01-2.png             rmd-logical_vectors_indexing2-1.png
python-call-stack-01.svg          python-sticky-note-variables-02.svg                    rmd-03-loops-R-inflammation-01-3.png  rmd-03-loops-R-loop-analyze-6.png             rmd-04-cond-inflammation-01-3.png             r-operations-across-axes.svg
python-call-stack-02.svg          python-sticky-note-variables-03.svg                    rmd-03-loops-R-inflammation-02-1.png  rmd-03-loops-R-loop-analyze-7.png             rmd-04-cond-using-conditions-01-1.png
python-call-stack-03.svg          rmd-01-starting-with-data-plot-avg-inflammation-1.png  rmd-03-loops-R-inflammation-02-2.png  rmd-03-loops-R-loop-analyze-8.png             rmd-04-cond-using-conditions-01-2.png
python-call-stack-04.svg          rmd-01-starting-with-data-plot-max-inflammation-1.png  rmd-03-loops-R-inflammation-02-3.png  rmd-03-loops-R-loop-analyze-9.png             rmd-12-supp-factors-adjusting-levels-1.png
python-call-stack-05.svg          rmd-01-starting-with-data-plot-min-inflammation-1.png  rmd-03-loops-R-loop-analyze-1.png     rmd-04-cond-conditional-challenge-hist-1.png  rmd-12-supp-factors-dropping-levels-1.png
python-call-stack-06.svg          rmd-02-func-R-rescale-test-1.png                       rmd-03-loops-R-loop-analyze-2.png     rmd-04-cond-conditional-challenge-hist-2.png  rmd-12-supp-factors-gender-counts-1.png

@fmichonneau
Copy link
Contributor

Yes, I believe that I added the correct prefix for the figures for each lesson. There might be some leftovers figures though.

@naupaka
Copy link
Member

naupaka commented Jul 20, 2016

Closing for now, feel free to re-open if problem is noticed elsewhere.

@naupaka naupaka closed this as completed Jul 20, 2016
rgaiacs pushed a commit to rgaiacs/swc-r-novice-gapminder that referenced this issue May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants