Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use two-digit identifier for generated figures #217

Closed
gvwilson opened this issue Jul 6, 2016 · 1 comment
Closed

Use two-digit identifier for generated figures #217

gvwilson opened this issue Jul 6, 2016 · 1 comment
Labels
enhancement Enhancement to lesson material good first issue Good issue for first-time contributors help wanted Looking for Contributors

Comments

@gvwilson
Copy link
Contributor

gvwilson commented Jul 6, 2016

@fmichonneau writes:

For the fig path, I think it has been inconsistent. Personally, I
think it's a good idea to given figures a prefix for each episode, so
we can see right away where the figures are coming from (and whether
some need to be deleted if they are not in use anymore). Therefore, in
the gapminder lesson, I set as a prefix the 2 digit number for the
episode (even if the lesson doesn't generate a figure), so each
episode should start with something like:

    ```{r, include=FALSE}
    source("../bin/chunk-options.R")
    knitr_fig_path("01-")
    ```
  1. Make this change to all .Rmd files.
  2. Clean out all old figures.

See also swcarpentry/r-novice-gapminder#166

@gvwilson gvwilson added enhancement Enhancement to lesson material good first issue Good issue for first-time contributors labels Jul 6, 2016
@gvwilson gvwilson added the help wanted Looking for Contributors label Aug 2, 2016
@butterflyskip
Copy link

Hi,
A couple of questions:

  1. Should I include _episodes_rmd/.Rhistory to the PR? (included it for now)
  2. What are considered "old figures" referred to above? I have not done that part in this PR

butterflyskip pushed a commit to butterflyskip/r-novice-inflammation that referenced this issue Dec 30, 2017
butterflyskip pushed a commit to butterflyskip/r-novice-inflammation that referenced this issue Jan 3, 2018
katrinleinweber added a commit that referenced this issue Apr 6, 2018
zkamvar pushed a commit that referenced this issue May 1, 2023
zkamvar pushed a commit that referenced this issue May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to lesson material good first issue Good issue for first-time contributors help wanted Looking for Contributors
Projects
None yet
Development

No branches or pull requests

2 participants