Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsetting countries for multi-panel figures in ggplot episode is too advanced #483

Closed
naupaka opened this issue Mar 10, 2019 · 5 comments
Closed
Labels
help wanted Looking for Contributors type:enhancement Propose enhancement to the lesson

Comments

@naupaka
Copy link
Member

naupaka commented Mar 10, 2019

I propose that instead of subsetting the plot to only show countries that begin with A or Z as facets (which I believe was done because the plot takes forever to generate if you try doing it for all countries at once), all of the subsetting code is removed and instead the plot is simply facetted by continent.

@naupaka naupaka added help wanted Looking for Contributors type:enhancement Propose enhancement to the lesson labels Mar 10, 2019
@liz-is
Copy link
Contributor

liz-is commented Mar 12, 2019

I taught at a workshop today that used this approach (facetting by continent) and it seemed to work well.

@ErinBecker ErinBecker added this to the June 2019 Release milestone May 14, 2019
@ElenaSal55
Copy link
Contributor

Hi, I was reading now the section 8, about creating graphics with ggplot2 and I noticed that the new script faceting by continent create a problem in the immidiately following script in "Modify text" and "Exporting the plot", because the object az.countries has not been created anymore in the Multi-panel figure section.

@ElenaSal55
Copy link
Contributor

I think the ploblem could be fix by changing in the section "Modifying text" the first line of the code changing from "data = az.countries" to "data=americas". The same issue can be solved in the section "Exporting the plot" changing the first line of script from "lifeExp_plot <- ggplot(data = az.countries, .." in "lifeExp_plot <- ggplot(data = americas,..". I am new so I don't know if this can be a valid contribution for the check out as instructor

@ElenaSal55
Copy link
Contributor

I solved the issue and created pull request #556

@jcoliver
Copy link
Contributor

Addressed in #549 and #556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Looking for Contributors type:enhancement Propose enhancement to the lesson
Projects
None yet
Development

No branches or pull requests

5 participants