Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gapminder link per issue521 #526

Closed
wants to merge 2 commits into from
Closed

Fix gapminder link per issue521 #526

wants to merge 2 commits into from

Conversation

kekoziar
Copy link
Contributor

Update link to Gapminder to point to wikipedia page, since gapminder site currently has what looks like formjacking attacks embedded in various images. See issue #521.

update link to Gapminder to point to wikipedia page, since gapminder site currently has what is looking like formjacking attacks embedded in various images. See issue #521.
update link to Gapminder to point to wikipedia page, since gapminder site currently has what is looking like formjacking attacks embedded in various images. See issue #521.
@naupaka
Copy link
Member

naupaka commented Jun 28, 2019

@kekoziar thanks! This needs to be against the master branch instead of gh-pages, because of how we have the Travis deployment set up. Sorry for the hassle

@kekoziar kekoziar closed this Jun 28, 2019
@kekoziar
Copy link
Contributor Author

Waiting on #488 to be completed...

@jcoliver
Copy link
Contributor

Updating the links to gapminder can be accomplished independently of changes to CONTRIBUTING.md. One just needs to request the pull comes from the master branch rather than the gh-pages branch.

zkamvar added a commit that referenced this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants