Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 03-seeking-help.Rmd #597

Merged
merged 1 commit into from Dec 5, 2019
Merged

Update 03-seeking-help.Rmd #597

merged 1 commit into from Dec 5, 2019

Conversation

@marklcrowe
Copy link
Contributor

marklcrowe commented Nov 28, 2019

Challenge 3 describes a "csv" file delimited by the tab character. By definition, a csv file is comma-delimited. I'd like to propose replacing references to csv with table/tabular to remove this inconsistency

Challenge 3 describes a "csv" file delimited by the tab character. By definition, a csv file is comma-delimited. I'd like to propose replacing references to csv with table/tabular to remove this inconsistency
> (tab) and the decimal point is a "." (period). This check for decimal
> separator is important, especially if you are working with international
> colleagues, because different countries have different conventions for the
> decimal point (i.e. comma vs period).
> hint: use `??csv` to lookup csv related functions.
> hint: use `??"read table"` to look up functions related to reading in tabular data.

This comment has been minimized.

Copy link
@jcoliver

jcoliver Dec 4, 2019

Contributor

??read table throws an error due to the space between "read" and "table" (Error: unexpected symbol in "??read table"). This statement should be revised.
UPDATE code as written does not produce error.

This comment has been minimized.

Copy link
@marklcrowe

marklcrowe Dec 4, 2019

Author Contributor

Hi @jcoliver, thanks for the feedback. You're right, ??read table gives an error, but ??"read table" should work. Do I need to escape the double-quotes, or did you just overlook them when checking?

This comment has been minimized.

Copy link
@jcoliver

jcoliver Dec 5, 2019

Contributor

Yar! I totally overlooked the double-quotes. But, when I run `??"read table", no results are returned. Should there be?

This comment has been minimized.

Copy link
@marklcrowe

marklcrowe Dec 5, 2019

Author Contributor

I've just tested it on a completely fresh install of R (current release - 3.6.1) and it comes up with base::base-defunct and utils::read.table - that's the same whether I'm using command line, the R app, or RStudio (on MacOS Mojave). Are you testing through RStudio? I know that for at least one of the recent RStudio releases, the "??" function didn't work at all.

This comment has been minimized.

Copy link
@jcoliver
@jcoliver

This comment has been minimized.

Copy link
Contributor

jcoliver commented Dec 4, 2019

Great point, @marklcrowe . Want to take a crack at the suggested revision?

@jcoliver jcoliver merged commit 0af834f into swcarpentry:master Dec 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.