-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update styles #694
Update styles #694
Conversation
This will fix #526
This is a modification for #501
R-based lessons might take a while to build because packages need to be compiled from source. RStudio Package Manager has compiled versions of packages for ubuntu distros starting with 16.04: https://packagemanager.rstudio.com/client/#/repos/1/overview I've added the necessary magic in the actions yaml to make it work.
This will fix #533
bin/lesson_check.py: allow 'caution' blockquote
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
This will address #544
... by using GFM (GitHub-flavored Markdown) parser (`kramdown-parser-gfm`) instead of the default one (`kramdown`). The default one fails to produce an AST (Abstract Syntax Tree) when there is no blank line before the line with the opening code fence. Related: - gettalong/kramdown#530 - Python-Markdown/markdown#807 Fixes: carpentries/styles#543
Fix Kramdown parser crash
...to make them distinguishable from regular text. And for accessibility!
Alas, it seems to fail as well. This is unfortunately preventing merged PRs from being incorporated into the site. |
There are two distinct things happening that are causing failures: First Failure: Build and DeployLog: https://github.com/swcarpentry/r-novice-gapminder/runs/2070029498?check_suite_focus=true
Context: 4 months ago, the Solution: remove Second FailureLog: https://github.com/swcarpentry/r-novice-gapminder/runs/2069657098?check_suite_focus=true
Context: This is my fault (carpentries/styles#536). I assumed that all lessons had a Solution: I will make a quick fix to the styles repository and make a new PR here. |
This updates styles to the current version (see #693 (comment) for impetus)
Process to update: