Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styles #694

Merged
merged 33 commits into from
Mar 9, 2021
Merged

Update styles #694

merged 33 commits into from
Mar 9, 2021

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Mar 9, 2021

This updates styles to the current version (see #693 (comment) for impetus)

Process to update:

git pull
git checkout -b update-styles
git pull https://github.com/carpentries/styles
# FIX MERGE CONFLICTS
git push -u origin update-styles

zkamvar and others added 30 commits December 3, 2020 15:49
This is a modification for #501
R-based lessons might take a while to build because packages need to be compiled from source. RStudio Package Manager has compiled versions of packages for ubuntu distros starting with 16.04: https://packagemanager.rstudio.com/client/#/repos/1/overview

I've added the necessary magic in the actions yaml to make it work.
bin/lesson_check.py: allow 'caution' blockquote
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
... by using GFM (GitHub-flavored Markdown) parser (`kramdown-parser-gfm`)
instead of the default one (`kramdown`).

The default one fails to produce an AST (Abstract Syntax Tree) when
there is no blank line before the line with the opening code fence.

Related:
 - gettalong/kramdown#530
 - Python-Markdown/markdown#807

Fixes: carpentries/styles#543
...to make them distinguishable from regular text. And for accessibility!
@jcoliver jcoliver merged commit e35940d into master Mar 9, 2021
@jcoliver jcoliver deleted the update-styles branch March 9, 2021 19:54
@jcoliver
Copy link
Contributor

jcoliver commented Mar 9, 2021

Alas, it seems to fail as well. This is unfortunately preventing merged PRs from being incorporated into the site.

@zkamvar
Copy link
Contributor Author

zkamvar commented Mar 10, 2021

There are two distinct things happening that are causing failures:

First Failure: Build and Deploy

Log: https://github.com/swcarpentry/r-novice-gapminder/runs/2070029498?check_suite_focus=true

processing file: _episodes_rmd/15-knitr-markdown.Rmd
Error in dyn.load(file, DLLpath = DLLpath, ...) : 
  unable to load shared object '/home/runner/work/_temp/Library/stringi/libs/stringi.so':
  libicui18n.so.60: cannot open shared object file: No such file or directory
Calls: source ... namespaceImport -> loadNamespace -> library.dynam -> dyn.load
Execution halted 
make: *** [Makefile:131: _episodes/15-knitr-markdown.md] Error 1

Context: 4 months ago, the deploy workflow was added to the R repositories: bfdfd47. This is failing because I think GitHub switched to using Ubuntu 20.04 recently, which screws up the C library used by {stringi} (see carpentries/styles#540 for frustration).

Solution: remove .github/workflows/deploy.yaml

Second Failure

Log: https://github.com/swcarpentry/r-novice-gapminder/runs/2069657098?check_suite_focus=true

Traceback (most recent call last):
  File "/home/runner/work/r-novice-gapminder/r-novice-gapminder/bin/lesson_check.py", line 566, in <module>
    main()
  File "/home/runner/work/r-novice-gapminder/r-novice-gapminder/bin/lesson_check.py", line 111, in main
    life_cycle = check_config(args.reporter, args.source_dir)
  File "/home/runner/work/r-novice-gapminder/r-novice-gapminder/bin/lesson_check.py", line 191, in check_config
    return config['life_cycle']
KeyError: 'life_cycle'
make: *** [Makefile:139: lesson-check-all] Error 1

Context: This is my fault (carpentries/styles#536). I assumed that all lessons had a life_cycle config parameter, which is clearly not true and it is causing an unrelated error on your lesson (and will cause errors on any other official lessons)

Solution: I will make a quick fix to the styles repository and make a new PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet