New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit filesystem/lesson examples for consistency #371

Open
gdevenyi opened this Issue May 9, 2016 · 8 comments

Comments

Projects
None yet
5 participants
@gdevenyi
Contributor

gdevenyi commented May 9, 2016

It seems we have had some drift between the two, need to resolve this

@rgaiacs

This comment has been minimized.

Collaborator

rgaiacs commented Jun 13, 2016

We have files duplicated in three places: filesystem/Users/nelle/, data-shell and shell-novice-data.zip.

Can we drop data-shell and generate shell-novice-data.zip based on filesystem/Users/nelle/?

Can we also drop shell-novice-data.zip and have it only in the release page?

@tomwright01

This comment has been minimized.

tomwright01 commented Jun 13, 2016

+1 for dropping the zip file. Following someone elses suggestion I recently started the lesson by getting participants to clone a repo containing the filesystem. This worked great.

Probably too great a change for today but I'd like to see a version controlled 'filesystem' repo that could be embedded in lessons as a submodule.

@gdevenyi

This comment has been minimized.

Contributor

gdevenyi commented Jun 13, 2016

We have one more set of duplications, the filesystem examples in the lessons themselves. We'll need to ensure those are synced with the filesystem as well.

@tomwright01 we can't go for an all-git solution for the filesystem, in case of SWC workshops where git isn't taught, they won't necessarily have a way to grab the filesystem

@jevbelikov

This comment has been minimized.

Contributor

jevbelikov commented Jun 19, 2016

in the zip archive there is an empty data-shell/Desktop/ sub-directory. Not sure why it is there. In any case, some example outputs (in 01-filedir.md) mention it and some don't.

@shwina

This comment has been minimized.

Member

shwina commented Jun 22, 2016

@rgaiacs.

We have files duplicated in three places: filesystem/Users/nelle/, data-shell and shell-novice-data.zip.

I don't understand. What is filesystem/Users/nelle? Also, what if some instructors want to use the bleeding-edge version of the lesson - wouldn't dropping the .zip file make things difficult?

@rgaiacs

This comment has been minimized.

Collaborator

rgaiacs commented Dec 7, 2016

@shwina Sorry for the long delay to reply your question.

What is filesystem/Users/nelle?

Did you get the answer for this question at #490?

Also, what if some instructors want to use the bleeding-edge version of the lesson - wouldn't dropping the .zip file make things difficult?

Long long time ago, at the time that we used, the now deprecated, https://github.com/swcarpentry/DEPRECATED-bc all instructors need to clone the repo and use the bleeding-edge version. Now we have a release process, https://github.com/swcarpentry/swc-releases, and we should suggest to instructors to use the last release and not the bleeding-edge version. Instructors that want to use the bleeding-edge version probably have a fork of the lesson and can generate the .zip file in 5 minutes or less.

@shwina

This comment has been minimized.

Member

shwina commented Dec 7, 2016

@rgaiacs - got it, thanks! Let's say we drop the .zip file in the bleeding-edge version of the lessons: (where) can we make it explicit that anyone teaching with this version should generate the .zip file themselves?

@rgaiacs

This comment has been minimized.

Collaborator

rgaiacs commented Dec 7, 2016

(where) can we make it explicit that anyone teaching with this version should generate the .zip file themselves?

Instructor guide? When we recreate it?

fmichonneau pushed a commit that referenced this issue Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment