Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grep example wrong in lessons 07-find #540

Closed
anenadic opened this issue Mar 30, 2017 · 2 comments
Closed

Grep example wrong in lessons 07-find #540

anenadic opened this issue Mar 30, 2017 · 2 comments

Comments

@anenadic
Copy link

$ grep "FE" $(find .. -name '*.pdb')
../data/pdb/heme.pdb:ATOM     25 FE           1      -0.924   0.535  -0.518

The above piece of code in lesson 07 (finding things) of shell-novice (http://swcarpentry.github.io/shell-novice/07-find/) does not work as there is no data file heme.pdb in the molecules directory. It also searched in the .. (parent) of the current directory instead of ../molecules.

@cjieming
Copy link

cjieming commented Apr 13, 2017

Hi, I just downloaded the shell-novice-data.zip file from here. It seems that under the previous directory of the 'writing' directory, there is a 'data' directory (different from the data dir within the 'writing' dir), and within this 'data' directory, there is a 'pdb' dir, and within this dir a 'heme.pdb' file. So I think this example seems correct.

@deppen8
Copy link
Contributor

deppen8 commented Sep 8, 2021

Closing as part of old issue cleanup. If there is still appetite for this change, we can reopen.

@deppen8 deppen8 closed this as completed Sep 8, 2021
fmichonneau added a commit to fmichonneau/shell-novice that referenced this issue Sep 9, 2021
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants