Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two exercises to 06-find/ #260

Closed
wants to merge 1 commit into from
Closed

Added two exercises to 06-find/ #260

wants to merge 1 commit into from

Conversation

cfgauss
Copy link

@cfgauss cfgauss commented Jan 5, 2016

This is part of the completion of Software Carpentry instructor training.

@gvwilson
Copy link
Contributor

gvwilson commented Jan 5, 2016 via email

@cfgauss
Copy link
Author

cfgauss commented Jan 5, 2016

Sorry for the anonymity. I added two exercises to 06-find in shell-novice.
-Bill McClung

@gvwilson
Copy link
Contributor

gvwilson commented Jan 5, 2016 via email

rgaiacs pushed a commit to rgaiacs/swc-shell-novice that referenced this pull request May 6, 2017
Resolve discrepancies in _extras/checkout.md
rgaiacs added a commit to rgaiacs/swc-shell-novice that referenced this pull request May 24, 2018
Move boilerplate files to their own file
@gdevenyi gdevenyi added the type:enhancement Propose enhancement to the lesson label Jan 21, 2019
@gcapes
Copy link
Contributor

gcapes commented Jan 22, 2019

Thanks for the PR @cfgauss!

These are great exercises (for advanced learners)!

Unfortunately, given how long this PR has been open, the formatting of the lesson and the contents of the molecules directory has changed a bit, and it would also be good to have a solution. Would you be interested in updating this PR, or should I finish it for you?

I would be tempted to merge the questions, because part 2 ,while useful, consolidates earlier material rather than the grep/find material.

The solution below works - is this what you had in mind?

for file in *.pdb
	do
		echo -n $file " "
		grep -c ATOM $file
	done | sort -k 2 -n

@cfgauss
Copy link
Author

cfgauss commented Jan 22, 2019

@gcapes I agree that this PR is "old" and doesn't pertain to the current version of the lesson. Your solution is what I had in mind if you decide to include a merged question. I'd be happy to close the pull request if you wish.

gcapes added a commit to gcapes/shell-novice that referenced this pull request Jan 23, 2019
@cfgauss cfgauss closed this Jan 23, 2019
@cfgauss
Copy link
Author

cfgauss commented Jan 23, 2019

Exercise has been commited to 07-find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Propose enhancement to the lesson
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants