Fix #518 for 07-find #528
Merged
Fix #518 for 07-find #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify example slightly to use files in the data-shell directory. This allows testing by learners.
Move solution to a show/hide solution box.
Add a file containing the text of the novel, so learners can actually test their code as they try to solve the problem. Update zip file containing data for exercises.
Add new directory and file to contain example data shown. Update zip archive to contain new file and directory.
|
@shwina |
shwina
reviewed
Apr 13, 2017
_episodes/07-find.md
Outdated
| > > ## Solution | ||
| > > Find all files with a `.dat` extension in the current directory. | ||
| > > Count the number of lines each of these files contains, then sort the output numerically. | ||
| > {: .solution} |
There was a problem hiding this comment.
How about we list (enumerate) them:
- Find all files with a
.datextension in the current directory - Count the number of lines in each of the above files
- Sort the output from step (2) numerically
| > > do | ||
| > > echo $sis: | ||
| > > grep -ocw $sis LittleWomen.txt | ||
| > > done |
There was a problem hiding this comment.
I'd say let's leave out the inferior solution altogether. Any advantage to keeping it?
There was a problem hiding this comment.
Only that the question suggests two different ways to achieve the outcome. I don't mind removing the alternative solution, so long as we also remove the hint which suggests it.
Or I could add a short note explaining that there is often more than one way to complete a programming task.
There was a problem hiding this comment.
Thanks, @gcapes - I'd suggest keeping the hint and adding the note.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide solutions and modify exercises to use the example data in data-shell.
Also add files and directories where using existing files wasn't possible.