-
-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #518 for 07-find #528
Merged
Merged
Fix #518 for 07-find #528
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
217b1f4
Add solution to 07 'Using grep'
gcapes dc07df0
Add solution to 07 'find pipeline reading comp'
gcapes 8b40048
Add solution to 07 'Matching and subtracting'
gcapes fe23fb3
Fix formatting for 07 'finding files..
gcapes 22c7745
Add solution to 07 'Little Women'
gcapes 0b83da0
Add solution to 07 'tracking a species'
gcapes 85f87ec
Add note to explain multiple solutions
gcapes af53148
Enumerate answer to pipeline reading comprehension
gcapes File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
2012-11-05,deer,5 | ||
2012-11-05,rabbit,22 | ||
2012-11-05,raccoon,7 | ||
2012-11-06,rabbit,19 | ||
2012-11-06,deer,2 | ||
2012-11-06,fox,4 | ||
2012-11-07,rabbit,16 | ||
2012-11-07,bear,1 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say let's leave out the inferior solution altogether. Any advantage to keeping it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only that the question suggests two different ways to achieve the outcome. I don't mind removing the alternative solution, so long as we also remove the hint which suggests it.
Or I could add a short note explaining that there is often more than one way to complete a programming task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @gcapes - I'd suggest keeping the hint and adding the note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!