DEV | My Own Spaces and Space Policy Update #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update base.html
… into development
… into development
Base Html SWE573 name updated. My Own Spaces functionality added. Space Model Updated to accommodate for policy requested in project. Space List front end updated. Define Policy button added.
sehmuzc
added
Type: Enhancement
Other than this, it looks great!! |
|
Ceyda, I have opened a new issue to track these four items as I wanted to
merge the code so that Şahin can work on the front-end side, I have
explained an issue to him.
…On Tue, Mar 14, 2023 at 12:25 AM Ceyda Düzgeç ***@***.***> wrote:
- We can use POSTING_PERMISSION_CHOICES from the models.py so we don't
need to copy-paste it to forms.py.
- Can you add an empty new line at the end of create_space.html please?
- Can you run the pre-commit linter to update the linter mistakes?
- What is the purpose of SpaceForm it actually seems like a PostForm?
Other than this, it looks great!!
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3RSIMTK4R6IATCS23XP2A3W36GF5ANCNFSM6AAAAAAVZTGF4E>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Space model has been updated with 3 policy options.
My Own Space functionality added.
Space Policy Definition change functionality added.