TypeScript definitions are incorrect.

[torkelrogstad]

onOpen and onClose does not take the popup as their argument, this should be updated in the definitions file.

[zenflow]

The definitions file for this package doesn't define those methods.. Is this an issue for sweetalert2?

[limonte]

Definitions seem to be fine:

• https://github.com/sweetalert2/sweetalert2/blob/master/sweetalert2.d.ts#L849
• https://github.com/sweetalert2/sweetalert2/blob/master/sweetalert2.d.ts#L865

[torkelrogstad]

After wrapping my modals in sweetalert2-react-content the onOpen and onClose functions no longer received the modals as their argument, and I had to call Swal.getPopup to get a hold of if. So what I'm trying to say, is that this package should redefine the onOpen and onClose signatures to be () => void instead of HTMLElement => void. Similar to what you do for the other changed props: https://github.com/sweetalert2/sweetalert2-react-content/blob/master/src/sweetalert2-react-content.d.ts#L36

[zenflow]

I think it would be better to make the fix so that those methods are called with the modal as their argument, and keep things in alignment with how sweetalert2 behaves without this extension (sweetalert2-react-content).

[limonte]

🎉 This issue has been resolved in version 2.0.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀