-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(api): falsy values in preConfirm (#1403)
* Changed check on preConfirmValue Currently the check on preConfirmValue is done on a falsy value. This include also 0, which could be a valid return value. Replaced it with a check for udnefined value, which is the only case where we may want to return something else * Added test for preConfirm returning undefined * Changed test for preConfirm return value Testing the code that causes the issue this time.
- Loading branch information
Showing
2 changed files
with
16 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters