Remove withNoNewKeyword enhancer #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limonte
force-pushed
the
breaking/remove-withNoNewKeyword
branch
3 times, most recently
from
e255bc5
to
3e82c05
Compare
Pull Request Test Coverage Report for Build 4486
💛 - Coveralls |
|
@zenflow would you have time to take a look at this PR? Also, do I understand correctly that we don't need |
Sure I'll have a look later today
Correct |
limonte
force-pushed
the
breaking/remove-withNoNewKeyword
branch
from
56f15ef
to
502e1fc
Compare
|
The bundle is 72B smaller now In total, we'll make it 1KB smaller than the prev major 🎉 @zenflow I'll merge this PR and continue with other tasks for the next major, feel free to give any feedback on this PR later. |
limonte
added a commit
that referenced
this pull request
Jan 18, 2019
From now on the recommended way to use SweetAlert2 is:
Swal.fire({...options})
BREAKING CHANGE: remove withNoNewKeyword enhancer (#1372)
limonte
pushed a commit
that referenced
this pull request
Jan 19, 2019
# [8.0.0](v7.33.1...v8.0.0) (2019-01-19) * BREAKING CHANGE: remove getButtonsWrapper() ([c93b5e3](c93b5e3)) * BREAKING CHANGE: close() as instance method (#1379) ([2519c17](2519c17)), closes [#1379](#1379) * BREAKING CHANGE: replace deprecated `jsnext:main` with `module` in package.json (#1378) ([1785905](1785905)), closes [#1378](#1378) * BREAKING CHANGE: drop Bower support (#1377) ([cb4ef28](cb4ef28)), closes [#1377](#1377) * BREAKING CHANGE: remove withNoNewKeyword enhancer (#1372) ([f581352](f581352)), closes [#1372](#1372) * BREAKING CHANGE: remove swal.noop() ([40d6fbb](40d6fbb)) * BREAKING CHANGE: rename $swal2-validationerror -> $swal2-validation-message (#1370) ([9d1b13b](9d1b13b)), closes [#1370](#1370) * BREAKING CHANGE: inputValidator and preConfirm should always resolve (#1383) ([fc70cf9](fc70cf9)), closes [#1383](#1383) * BREAKING CHANGE: remove setDefault and resetDefaults (#1365) ([97c1d7c](97c1d7c)), closes [#1365](#1365) * BREAKING CHANGE: remove extraParams (#1363) ([5125491](5125491)), closes [#1363](#1363) * BREAKING CHANGE: remove showValidationError and resetValidationError (#1367) ([50a1eff](50a1eff)), closes [#1367](#1367) * BREAKING CHANGE: remove useRejections and expectRejections (#1362) ([f050caf](f050caf)), closes [#1362](#1362) * BREAKING CHANGE: dismissReason: overlay -> backdrop (#1360) ([d05bf33](d05bf33)), closes [#1360](#1360) * BREAKING CHANGE: drop Android 4.4 support (#1359) ([c0eddf3](c0eddf3)), closes [#1359](#1359) ### Features * **api:** add update() method ([#1186](#1186)) ([348e8b7](348e8b7)) ### BREAKING CHANGES * close() as instance method (#1379) * drop Android 4.4 support (#1359) * replace deprecated `jsnext:main` with `module` in package.json (#1378) * drop Bower support (#1377) * remove withNoNewKeyword enhancer (#1372) * remove swal.noop() * rename $swal2-validationerror -> $swal2-validation-message (#1370) * inputValidator and preConfirm should always resolve (#1383) * remove setDefault and resetDefaults (#1365) * remove extraParams (#1363) * remove showValidationError and resetValidationError (#1367) * remove useRejections and expectRejections (#1362) * dismissReason: overlay -> backdrop (#1360) * remove getButtonsWrapper()
|
🎉 This has been shipped in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1368
From now on the recommended way to use SweetAlert2 is: