Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new logo to README #1687

Merged
merged 3 commits into from Jul 25, 2019

Conversation

@serenaperora
Copy link
Contributor

serenaperora commented Jul 24, 2019

Hi @limonte, along with the changes in sweetalert2/sweetalert2.github.io#81 I also re-designed the logo for the README.

This one is slightly different from the one on the documentation home page: the donut is in fact slightly offset to the right. If you don't like that (@gverni doesn't 馃槃) I can always use the following instead:

logo-e-marchio_ciamb-dentro

Let me know what do you think.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 24, 2019

Pull Request Test Coverage Report for Build 5224

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.825%

Totals Coverage Status
Change from base Build 5217: 0.0%
Covered Lines: 1303
Relevant Lines: 1379

馃挍 - Coveralls
Copy link
Member

limonte left a comment

Good day, @serenaperora and thank you for this PR!

I also prefer the more symmetrical logo :)

The logo with the donut moved to the right will cause small issues with centering the logo on the page, without additional margin, it will look like not centered properly on a page.

Also, please remove the white background and make it transparent as in the current one.

Thank you in advance!

@serenaperora

This comment has been minimized.

Copy link
Contributor Author

serenaperora commented Jul 25, 2019

Hi @limonte, it make sense. I changed the logo to the symmetrical one with transparent background. Have a look and let me know.

I'm also working on the "social preview" image. But since that is in the GitHub settings, I'll attach it in a comment later on.

@gverni gverni requested a review from limonte Jul 25, 2019
@serenaperora

This comment has been minimized.

Copy link
Contributor Author

serenaperora commented Jul 25, 2019

Hi @limonte as promised I added the social preview png in the assets folder (since I think I cannot change it). If you like it either you or @gverni can change it in the github settings.

Copy link
Member

limonte left a comment

Perfect! Thank you so much @serenaperora!

@limonte limonte merged commit 9af88fc into sweetalert2:master Jul 25, 2019
6 checks passed
6 checks passed
LGTM analysis: JavaScript No code changes detected
Details
CodeFactor No issues found.
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@limonte

This comment has been minimized.

Copy link
Member

limonte commented Aug 2, 2019

馃帀 This PR is included in version 8.14.1 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@limonte limonte added the released label Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.