-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply new logo to README #1687
Apply new logo to README #1687
Conversation
Pull Request Test Coverage Report for Build 5224
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good day, @serenaperora and thank you for this PR!
I also prefer the more symmetrical logo :)
The logo with the donut moved to the right will cause small issues with centering the logo on the page, without additional margin, it will look like not centered properly on a page.
Also, please remove the white background and make it transparent as in the current one.
Thank you in advance!
Hi @limonte, it make sense. I changed the logo to the symmetrical one with transparent background. Have a look and let me know. I'm also working on the "social preview" image. But since that is in the GitHub settings, I'll attach it in a comment later on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you so much @serenaperora!
🎉 This PR is included in version 8.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi @limonte, along with the changes in sweetalert2/sweetalert2.github.io#81 I also re-designed the logo for the README.
This one is slightly different from the one on the documentation home page: the donut is in fact slightly offset to the right. If you don't like that (@gverni doesn't 😄) I can always use the following instead:
Let me know what do you think.