allow more adc channels than dac channels #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these ABFs are not related to this PR and have bad headers which contain binary data this commit revers them to their original state so they dont appear as modified by this PR
reverts to original behavior discussed in swharden#121/swharden#122
addresses swharden#121 where a hard crash would occur if an ABF were loaded with more ADC channels than DAC channels If a channel name or units cannot be properly found, it uses None instead
prevents hard crashes when number of ADCs is greater than number of DACs swharden#121/swharden#122
|
Thanks @pnewstein! This looks to be fixed now and I'll publish an update package on pypi here in a few minutes. Thanks again for the bug report and the fix! 👍 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121 but causes
abf.sweepUnisC,abf.sweepLabelC, andabf.sweepEpochsto be undefined in some cases.