New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect to IP but send a user-specified hostname in the SNI field [was: Do we have feature like curl's --resolve
option?]
#115
Comments
By "IP-based SNI" I assume what you mean is "I want to connect to a specific IP address but send a hostname in the SNI field". In which case: yes, we could plausibly support that use-case. |
However, I should stress that we don't support it today so far as I know. All the building blocks are there in NIO though. |
Thanks! |
@nixzhu sure you want to close this issue? We could keep at as a feature request for async-http-client. If you'd like to give it a shot you might even want to try writing a patch? We're here to help :) |
@weissi I like it becomes a feature request, but I'm not capable for the implementation for now. |
--resolve
option?--resolve
option?]
This shouldn't be too hard to implement. The line that needs changing is this one:
in If In the future, this should check if we have an SNI hostname override in our configuration, if yes: use the override, if no: do the old logic. If you feel like giving the implementation a go and have any questions, please reach out :) |
I want to work on this issue.
So we should have SNI hostname attribute in |
@shekhar-rajak probably |
this would be extremely useful for us also |
@dellgreen would you be up to taking a stab at the implementation? |
With curl's
--resolve
option, it should supports IP based SNI.Ref https://curl.haxx.se/docs/manpage.html#--resolve
The text was updated successfully, but these errors were encountered: