-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Licence is invalid #523
Comments
cc @tomerd |
We don't need @tomerd's help here, we can just update that file. Incidentally I don't believe that it renders the license invalid in any way, it's just a bit less convenient to copy into forks. |
Who's the code owner here? Swift, Apple or the SSWG? I'm only asking as we need to add a licence for the VSCode extension which is how I stumbled upon this |
|
@0xTim I think the The quoted line is after the And from what I can tell, each file in AHC has the correct information (ie. the placeholders replaced with the real info). |
Hmm maybe you're right, in which case ignore me then! |
I think same as @weissi -- this is just the section of the license that says "this is how you apply it" -- the actual copyright headers in the actual files have the right info. We can confirm with some actual legal authority; but another point of reference is Akka and Netty, both of which do the same thing: https://github.com/akka/akka/blob/main/LICENSE https://github.com/netty/netty/blob/4.1/LICENSE.txt - the file is just the template with placeholders. I believe this/these issue(s) should be closed with no action taken. |
The Apache licence added to the project does not contain a copyright year or name of the copyright holder - https://github.com/swift-server/async-http-client/blob/main/LICENSE.txt#L190
This should probably be fixed...
The text was updated successfully, but these errors were encountered: