Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to NIOSSL 2.12.x and fix tests #356

Merged
merged 1 commit into from Apr 27, 2021

Conversation

Davidde94
Copy link
Collaborator

The way NIOSSL propagated TLS handshake fails was incorrect. This was fixed and released in NIOSSL 2.12.

This PR updates to NIOSSL 2.12.x, and fixes tests that were broken as part of the change.

@swift-server-bot
Copy link

Can one of the admins verify this patch?

5 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, lgtm!

@weissi
Copy link
Contributor

weissi commented Apr 27, 2021

@swift-server-bot add to allowlist

@weissi weissi merged commit f352103 into swift-server:main Apr 27, 2021
@Davidde94 Davidde94 deleted the de/update-niossl branch April 27, 2021 14:48
@weissi weissi added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants