-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog windows quit Unexpectedly in 2.4.1 #351
Comments
I dug through this and can confirm this bug. Easy to reproduce:
Sending a "height" adjustment command to any running dialog causes a crash. Confirmed this is an issue in 2.4.1, 2.4.0 does not display this behavior. @jeden-92 to side step this in the mean time, you can adjust that script to have the initial dialog set to the desired height and comment out the line with |
@BigMacAdmin the height adjustment was the one thing i didn't think to check, this is good to know i will apply this fix in the interim. |
cheers for that - I'll have a look and see what's causing the crash |
solved it - came about due to a change where I moved the window management code out of the SwiftUI app lifecycle and into an AppDelegate. In that context, the main observable object that contains the app state is not available and the Probably needs some more cleanup as I think that variable now goes unused but works in limited testing. |
Probably it's obvious (being part of the |
…ich may be nil, provide a default if the unrwap fails Fixes swiftDialog#351
Describe the bug
Since updating to 2.4.1 my script which launches a dialog and then updates it with the update dialog command, will show the first dialog then the script progresses and the dialog will quit but the script still completes in the background. gives this error in the cmd output /usr/local/bin/dialog: line 18: 2296 Trace/BPT trap: 5 launchctl asuser "$uid" sudo -u "$currentUser" "$@"
To Reproduce
Steps to reproduce the behavior:
my script is a clone of this script https://github.com/PezzaD84/Assemble so running the unedited version will reproduce the issue, if run with an older version of dialog the script performs as expected. this occurs on ventura and sonoma.
Expected behavior
the dialog should not quit
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: