-
-
Notifications
You must be signed in to change notification settings - Fork 91
-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent title cycle duration #347
Comments
Hey @cwernert, awesome bug report, thank you. It is indeed a bug introduced in 1.4.4, here is what happens: SwiftBar cycles through titles every 5 seconds and plugin updates every 10 seconds, they overlap and as soon as the menu bar switches to Title 2 SwiftBar updates the plugin and menu bar goes back to Title 1. This didn't happen before 1.4.4 because SwiftBar would NOT refresh the menu bar if plugin output didn't change since the last time. I changed this behaviour when implementing #321, let me look into it |
Hey @melonamin - thanks for such a quick analysis, and even moreso for this seriously awesome tool! We certainly love the new "Dim on manual refresh" feature; so it's worth ironing out a few minor kinks. That totally makes sense - and it seems like a quick workaround for the meantime would be adjusting the frequency of the plugin. As long as "frequency > 5 * # of titles + 5" we get to see each one sufficiently :) I wonder whether it's possible to get the best of both worlds, ie. when a user manually clicks "refresh" we force a menu bar update regardless of whether the content has changed - otherwise don't refresh the menu bar if the output hasn't changed. Is that technically feasible? Alternatively (this might be a huge lift so feel free to disregard), would it help if:
For example, if a plugin declares That may or may not be a terrible idea, but I'll keep brainstorming to see if I can come up with a creative suggestion :) |
Heu @cwernert, do you mind trying this beta build? It should address this issue |
Looks brilliant @melonamin; love your work! |
Thank you @melonamin! I also tested it, and the issue appears to be fixed, indeed. I appreciate your work! |
Describe the bug
When more than one title is output to the header:
To Reproduce
Steps to reproduce the behavior:
---
)Expected behavior
Screenshots
https://cdn.zappy.app/va6dcd69c28fedf440a101c61a04693f9.mp4
See 00:27, Menu Item 2 flashes at ~00:28
Environment:
Plugin Example:
Additional Context:
The text was updated successfully, but these errors were encountered: