Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Indicator #321

Closed
carlosfrodriguez opened this issue May 23, 2022 · 6 comments
Closed

Refresh Indicator #321

carlosfrodriguez opened this issue May 23, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@carlosfrodriguez
Copy link

Add an option to have a visual feedback when the plugins are refreshing.

This was done in BitBar and it is also present in xbar, would be a nice addition to also preserve that feature in SwiftBar (for sure is not needed to be enabled by default)

@melonamin melonamin self-assigned this May 29, 2022
@melonamin melonamin added the enhancement New feature or request label May 29, 2022
@melonamin melonamin added this to the 1.4.4 milestone May 29, 2022
@melonamin
Copy link
Contributor

I assume you want to see it only for manual Refresh, correct?

@carlosfrodriguez
Copy link
Author

carlosfrodriguez commented May 30, 2022

Yes, that would be fine

@garyking
Copy link

garyking commented Jul 11, 2022

Yes, this is a good idea. For manual refreshes in SwiftBar, the plugin's text should grey out while it refreshes, as it currently does in xbar.

@garyking
Copy link

Thanks for the changes! Please close this issue when it's been released, so we are notified.

@garyking
Copy link

Thanks. I've updated to the new version just now. But the plugins are not dimming when being manually refreshed, using open -g swiftbar://refreshplugin?name=plugin.1m.js. The command itself works fine as always, but the plugin does not get dimmed while refreshing (such as while it grabs data from the web).

@melonamin
Copy link
Contributor

Yeah, it doesn't do that... Currently it dims the menu on clicking SwiftBar -> Refresh All and a menu item with ... | refresh=true.
URL scheme is not included :(

Created #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants