Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URLs that now redirect #113

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Update URLs that now redirect #113

merged 1 commit into from
Mar 9, 2023

Conversation

flbn
Copy link
Contributor

@flbn flbn commented Mar 8, 2023

There are several links to the previous url where the Swift book was published, this PR here just gets rid of the main offender in the README. i'm hesitant to touch the other links, so i'll just drop this search for posterity: https://github.com/search?q=repo%3Aapple%2Fswift-book%20https%3A%2F%2Fdocs.swift.org%2Fswift-book%2F&type=code

as per #72

@flbn flbn changed the title quick update to main url quick update to old urls that now redirect Mar 8, 2023
@flbn
Copy link
Contributor Author

flbn commented Mar 8, 2023

turns out that search revealed only one other link that wasn't updated in the TSPL.docc/header-staging.html file. grepping and gh search don't result in any other hits, so this should be all of them?

@amartini51 amartini51 changed the title quick update to old urls that now redirect Update URLss that now redirect Mar 8, 2023
@amartini51 amartini51 changed the title Update URLss that now redirect Update URLs that now redirect Mar 8, 2023
@amartini51
Copy link
Member

Thanks! Do you mind if I revise the commit messages to be a little more informative and force-push to your branch?

@flbn
Copy link
Contributor Author

flbn commented Mar 8, 2023

not a problem!

This URL changed now that TSPL is being published using DocC.  The old
URL still works, but using the current URL avoids sending folks through
a redirect page.
@amartini51
Copy link
Member

@flbn Ok if I merge now, using the rewritten commit 63d118e?

@amartini51 amartini51 self-requested a review March 9, 2023 00:20
@flbn
Copy link
Contributor Author

flbn commented Mar 9, 2023

yup👌🏽

@amartini51 amartini51 merged commit 8f81885 into swiftlang:main Mar 9, 2023
@flbn flbn deleted the main-readme-url-update branch March 9, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants