-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some guidelines violations and typos #202
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch looks fine to me, Jordan do you have a specific concern? |
Yes, see the comment on the second commit. (I have no problem with this if the test passes, just wanted to make sure @valzevul did check that.) |
I'll run tests and merge. |
The tests broke:
@valzevul Please run |
@valzevul @gribozavr @jrose-apple it's already merged #610 you can close this PR |
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Fix + and - operations on DispatchTime and DispatchWallTime
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Fix + and - operations on DispatchTime and DispatchWallTime Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
dabelknap
added a commit
to dabelknap/swift
that referenced
this pull request
Jan 23, 2019
…lines-after-comments Fix extra blank lines after trailing comments in member decl blocks.
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
Fix bug that caused the rootId of a node to not be updated if it was created by a replacing* function
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Update hash so that Kronos builds with Swift 4
DougGregor
pushed a commit
to DougGregor/swift
that referenced
this pull request
Apr 28, 2024
- Use durable GUID generation for auto-generation of the GUID. - Combine the platform definitions into a singular source to avoid drift. This avoids having to keep the variants in sync and provides an easier upgrade path. This is the first step towards enabling a non-admin experience for users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of typos and update whitespaces to look more general.