Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some guidelines violations and typos #202

Closed
wants to merge 3 commits into from

Conversation

valzevul
Copy link

@valzevul valzevul commented Dec 4, 2015

Fix a couple of typos and update whitespaces to look more general.

@lattner
Copy link
Contributor

lattner commented Dec 5, 2015

This patch looks fine to me, Jordan do you have a specific concern?

@jrose-apple
Copy link
Contributor

Yes, see the comment on the second commit.

(I have no problem with this if the test passes, just wanted to make sure @valzevul did check that.)

@gribozavr
Copy link
Contributor

I'll run tests and merge.

@gribozavr gribozavr self-assigned this Dec 10, 2015
@gribozavr
Copy link
Contributor

The tests broke:

<src>/swift/test/SILGen/coverage_member_closure.swift:6:16: warning: will never be executed
    if (false) { // CHECK: [[@LINE]]:16 -> [[@LINE+2]]:6 : 1
               ^
<src>/swift/test/SILGen/coverage_member_closure.swift:6:8: note: condition always evaluates to false
    if (false) { // CHECK: [[@LINE]]:16 -> [[@LINE+2]]:6 : 1
       ^
<src>/swift/test/SILGen/coverage_member_closure.swift:13:12: error: expected string not found in input
 // CHECK: [[@LINE+1]]:55 -> [[@LINE+1]]:77 : 2

@valzevul Please run utils/build-script -RT and update the pull request.

@gribozavr gribozavr removed their assignment Dec 11, 2015
@frootloops
Copy link
Contributor

@valzevul @gribozavr @jrose-apple it's already merged #610 you can close this PR

@gribozavr gribozavr closed this Dec 17, 2015
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
Fix + and - operations on DispatchTime and DispatchWallTime
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
Fix + and - operations on DispatchTime and DispatchWallTime

Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
dabelknap added a commit to dabelknap/swift that referenced this pull request Jan 23, 2019
…lines-after-comments

Fix extra blank lines after trailing comments in member decl blocks.
maldahleh pushed a commit to maldahleh/swift that referenced this pull request Oct 26, 2020
Fix bug that caused the rootId of a node to not be updated if it was created by a replacing* function
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
Update hash so that Kronos builds with Swift 4
DougGregor pushed a commit to DougGregor/swift that referenced this pull request Apr 28, 2024
- Use durable GUID generation for auto-generation of the GUID.
- Combine the platform definitions into a singular source to avoid
  drift.

This avoids having to keep the variants in sync and provides an easier
upgrade path.  This is the first step towards enabling a non-admin
experience for users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants