Fix typos in docs / comments / method name #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…No code change (shouldn't break anything)
| @@ -1069,7 +1069,8 @@ static bool hoistBoundsChecks(SILLoop *Loop, DominanceInfo *DT, SILLoopInfo *LI, | |||
|
|
|||
| auto *Preheader = Loop->getLoopPreheader(); | |||
| if (!Preheader) { | |||
| // TODO: create one if neccessary. | |||
| // TODO: create one if necessary. | |||
|
|
|||
There was a problem hiding this comment.
Please remove extra space.
|
Otherwise looks good to me. |
|
OK, looks good! Please squash the commit and I'll merge it in. |
The cmark_node struct and the node.h header are private.
I filed this under Radar rather than bugs.swift.org because it's /only/ our CI system that's failing, and external contributors have no insight into that anyway. Hopefully I'll be able to get to the bottom of this soon.
This is needed for Xcode support, even though it appeared dead within the Swift repo itself.
|
Looks great. |
cwillmor
added a commit
that referenced
this pull request
Dec 5, 2015
Fix typos in docs / comments / method name
|
Thanks for putting this together! |
dabelknap
pushed a commit
to dabelknap/swift
that referenced
this pull request
Mar 19, 2019
More gracefully check that an input file exists
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Updates ObjectMapper hash to build against 4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across some typos while reading source, and fixed other occurrences of same typo. All but one change involve documentation / comments. The only altered source code concerned a method name in Dominance.h / Dominance.cpp.