[stdlib] Improve error messages when snake case conversion is used. #24904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`convertFromSnakeCase` and `convertToSnakeCase` are not inverses of each other for keys like "pictureURL" (which roundtrips to "pictureUrl"). This does not fix the underlying issue, but improves the error message if this situation is detected.
|
cc @itaiferber |
|
This looks reasonable to me — added @parkera for any input or comments. |
|
@swift-ci Please smoke test |
parkera
approved these changes
May 21, 2019
|
Could we merge this? |
|
@swift-ci Smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convertFromSnakeCaseandconvertToSnakeCaseare not inverses of each other for keys like "pictureURL" (which roundtrips to "pictureUrl").This does not fix the underlying issue, but improves the error message if this situation is detected.
Discussions of the underlying issue, which this PR does not address:
https://forums.swift.org/t/handling-edge-cases-in-jsonencoder-jsondecoder-key-conversion-strategies-sr-6629/12384
#14039