[Autodiff] Derivative Registration for the Get and Set Accessors #32614

ematejska · 2020-06-30T04:10:36Z

This implements the support for@derivative derivative registration for the get and set accessors (https://bugs.swift.org/browse/TF-1193.). The class set accessor is not yet supported.

Done together with @dan-zheng

… found.

- Improve diagnostic message. - Clean up code and tests. - Delete unrelated nested type `@derivative` attribute tests.

Blocked by SR-13096.

… label.

ematejska · 2020-06-30T04:13:47Z

@swift-ci please smoke test

ematejska · 2020-06-30T04:13:56Z

@swift-ci please test

dan-zheng

Nice work!

utils/gyb_syntax_support/AttributeNodes.py

lib/Parse/ParseDecl.cpp

lib/Sema/TypeCheckAttr.cpp

dan-zheng

When syntax definitions are changed, I believe apple/swift-syntax needs to be updated with newly generated syntax files. This is necessary to pass --swiftsyntax-verify-generated-files.

Here's an example PR. I think you can regenerate swift-syntax files locally with utils/build-script --infer --swiftsyntax.

lib/Sema/TypeCheckAttr.cpp

swift-ci · 2020-06-30T06:27:33Z

Build failed
Swift Test OS X Platform
Git Sha - ab5bd6b

Co-authored-by: Dan Zheng <danielzheng@google.com>

test/AutoDiff/Sema/derivative_attr_type_checking.swift

Re-apply `git clang-format`.

gottesmm · 2020-06-30T20:17:57Z

Before this lands, can you be sure to re-base and clean up the git history by smooshing commits that don't stand on their own. Thanks!

…accessor is not found on functions resolved.

…ple/swift into autodiff-accessor-derivatives

ematejska · 2020-07-01T00:08:24Z

@swift-ci please smoke test

ematejska · 2020-07-01T00:08:30Z

@swift-ci please test

swift-ci · 2020-07-01T00:11:16Z

Build failed
Swift Test Linux Platform
Git Sha - ab5bd6b

swift-ci · 2020-07-01T00:12:00Z

Build failed
Swift Test OS X Platform
Git Sha - ab5bd6b

dan-zheng

Nice!

@ematejska: would you like to preemptively squash commits? Or you could "Squash and merge" with a short commit description.

lib/Sema/TypeCheckAttr.cpp

Co-authored-by: Dan Zheng <danielzheng@google.com>

ematejska · 2020-07-01T04:38:39Z

@swift-ci please smoke test

ematejska · 2020-07-01T04:38:47Z

@swift-ci please test

swift-ci · 2020-07-01T04:41:18Z

Build failed
Swift Test OS X Platform
Git Sha - e7ddf70

swift-ci · 2020-07-01T04:41:37Z

Build failed
Swift Test Linux Platform
Git Sha - e7ddf70

ematejska · 2020-07-01T14:22:13Z

@swift-ci please test os x platform

ematejska · 2020-07-01T14:22:43Z

@swift-ci please smoke test os x platform

ematejska · 2020-07-01T16:25:33Z

Nice!

@ematejska: would you like to preemptively squash commits? Or you could "Squash and merge" with a short commit description.

I'll do the Squash and merge.

ematejska · 2020-07-01T16:26:10Z

When syntax definitions are changed, I believe apple/swift-syntax needs to be updated with newly generated syntax files. This is necessary to pass --swiftsyntax-verify-generated-files.

Here's an example PR. I think you can regenerate swift-syntax files locally with utils/build-script --infer --swiftsyntax.

I'll try to do this today.

swift-ci · 2020-07-01T16:36:38Z

Build failed
Swift Test OS X Platform
Git Sha - 16a9b17

…32614)

ematejska · 2020-07-01T19:37:00Z

Please test with:
swiftlang/swift-syntax#225

@swift-ci please test os x platform

ematejska and others added 9 commits June 25, 2020 00:20

initial changes

ce3162d

Add tests, undo unnecessary changes.

c96bd29

Fixing up computed properties accessors and adding tests for getters.

83231e9

Adding nested type testcase

f18a2fe

Fixing error message for when accessor is referenced but not acutally…

0a568d9

… found.

Cleanup.

8a463c0

- Improve diagnostic message. - Clean up code and tests. - Delete unrelated nested type `@derivative` attribute tests.

Temporarily disable class subscript setter derivative registration test.

8da86cc

Blocked by SR-13096.

Adding libsyntax integration and fixing up an error message.

1586da6

Added a helper function for checking if the next token is an accessor…

0107d48

… label.

ematejska requested a review from dan-zheng June 30, 2020 04:10

Merge branch 'master' into autodiff-accessor-derivatives

ab5bd6b

dan-zheng requested a review from rxwei June 30, 2020 05:06

dan-zheng reviewed Jun 30, 2020

View reviewed changes

rxwei reviewed Jun 30, 2020

View reviewed changes

lib/Sema/TypeCheckAttr.cpp Outdated Show resolved Hide resolved

ematejska and others added 4 commits June 30, 2020 08:22

Update utils/gyb_syntax_support/AttributeNodes.py

92f9988

Co-authored-by: Dan Zheng <danielzheng@google.com>

Update lib/Parse/ParseDecl.cpp

03d21e8

Co-authored-by: Dan Zheng <danielzheng@google.com>

Add end-to-end derivative registration tests.

f1f6034

NFC: run git clang-format.

2def6ee

dan-zheng reviewed Jun 30, 2020

View reviewed changes

test/AutoDiff/Sema/derivative_attr_type_checking.swift Show resolved Hide resolved

dan-zheng added 2 commits June 30, 2020 18:22

NFC: clean up formatting.

a319546

Re-apply `git clang-format`.

Clarify parsing ambiguity FIXME comments.

bf998e1

ematejska added 2 commits June 30, 2020 16:59

Adding couple of more testcases and fixing up error message for when …

586cb24

…accessor is not found on functions resolved.

Merge branch 'autodiff-accessor-derivatives' of https://github.com/ap…

e7ddf70

…ple/swift into autodiff-accessor-derivatives

dan-zheng approved these changes Jul 1, 2020

View reviewed changes

lib/Sema/TypeCheckAttr.cpp Outdated Show resolved Hide resolved

rxwei approved these changes Jul 1, 2020

View reviewed changes

Update lib/Sema/TypeCheckAttr.cpp

16a9b17

Co-authored-by: Dan Zheng <danielzheng@google.com>

ematejska added a commit to ematejska/swift-syntax that referenced this pull request Jul 1, 2020

Autodiff updates for enabling accessor deriviatives (swiftlang/swift#…

3469f21

…32614)

ematejska mentioned this pull request Jul 1, 2020

Autodiff updates for enabling accessor derivatives … swiftlang/swift-syntax#225

Merged

akyrtzi merged commit fbec91a into master Jul 2, 2020

akyrtzi deleted the autodiff-accessor-derivatives branch July 2, 2020 03:15

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Autodiff] Derivative Registration for the Get and Set Accessors #32614

[Autodiff] Derivative Registration for the Get and Set Accessors #32614

ematejska commented Jun 30, 2020

ematejska commented Jun 30, 2020

ematejska commented Jun 30, 2020

dan-zheng left a comment

dan-zheng left a comment

swift-ci commented Jun 30, 2020

gottesmm commented Jun 30, 2020

ematejska commented Jul 1, 2020

ematejska commented Jul 1, 2020

swift-ci commented Jul 1, 2020

swift-ci commented Jul 1, 2020

dan-zheng left a comment

ematejska commented Jul 1, 2020

ematejska commented Jul 1, 2020

swift-ci commented Jul 1, 2020

swift-ci commented Jul 1, 2020

ematejska commented Jul 1, 2020

ematejska commented Jul 1, 2020

ematejska commented Jul 1, 2020

ematejska commented Jul 1, 2020

swift-ci commented Jul 1, 2020

ematejska commented Jul 1, 2020

[Autodiff] Derivative Registration for the Get and Set Accessors #32614

[Autodiff] Derivative Registration for the Get and Set Accessors #32614

Conversation

ematejska commented Jun 30, 2020

ematejska commented Jun 30, 2020

ematejska commented Jun 30, 2020

dan-zheng left a comment

Choose a reason for hiding this comment

dan-zheng left a comment

Choose a reason for hiding this comment

swift-ci commented Jun 30, 2020

gottesmm commented Jun 30, 2020

ematejska commented Jul 1, 2020

ematejska commented Jul 1, 2020

swift-ci commented Jul 1, 2020

swift-ci commented Jul 1, 2020

dan-zheng left a comment

Choose a reason for hiding this comment

ematejska commented Jul 1, 2020

ematejska commented Jul 1, 2020

swift-ci commented Jul 1, 2020

swift-ci commented Jul 1, 2020

ematejska commented Jul 1, 2020

ematejska commented Jul 1, 2020

ematejska commented Jul 1, 2020

ematejska commented Jul 1, 2020

swift-ci commented Jul 1, 2020

ematejska commented Jul 1, 2020