[stdlib] Fix Int(_:radix:) accepting unintentional cases (SR-187) #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PatrickPijnappel Thank you, this LGTM, but please re-format to 80 columns. |
| guard let result = _parseUnsignedAsciiAsUIntMax(digitsUTF16, radix, maximum) else { return nil } | ||
| // Disallow < 0 | ||
| if hasMinus && result != 0 { return nil } | ||
| // Return |
There was a problem hiding this comment.
I don't think // Return is a useful comment :)
There was a problem hiding this comment.
The comments are intended as headings for code grouping (instead of newlines) so you can quickly skim the algorithm and it's structure/flow just from those headings. But I agree // Return in itself it not a very useful comment :). I'll can replace it by a slightly more useful heading, e.g. // Valid result. (to indicate the algorithm early-returned all invalids), or remove it (/replace it by a newline) if you prefer ;).
|
Added terminating periods and reformatted to fit 80 columns. |
gribozavr
added a commit
that referenced
this pull request
Dec 21, 2015
[stdlib] Fix Int(_:radix:) accepting unintentional cases (SR-187)
Closed
gottesmm
added a commit
to gottesmm/swift
that referenced
this pull request
Sep 28, 2016
…ed out hashes for each repo. I think update-checkout is growing to the point, we should probably rename it to something like repo-tool. The output of this command looks as follows: clang 973bd1a Merge remote-tracking branch 'origin/swift-3.1-branch' into stable cmark 5af77f3 Merge pull request swiftlang#95 from kainjow/master compiler-rt 1f24bd0 Merge remote-tracking branch 'origin/swift-3.1-branch' into stable llbuild c324ee3 Merge pull request swiftlang#35 from tinysun212/pr-cygwin-1 lldb f6a5830 Adjust LLDB for changes to the layout of _SwiftTypePreservingNSNumber llvm 52482d0 Merge remote-tracking branch 'origin/swift-3.1-branch' into stable swift 45f3d2a [update-checkout] Add a small tool to dump hashes for all of the checkout repos. swift-corelibs-foundation cc5985e Loopback tests for URLSession (swiftlang#613) swift-corelibs-libdispatch ba7802e Merge pull request swiftlang#178 from dgrove-oss/depend-on-swiftc swift-corelibs-xctest 51b419d Merge pull request swiftlang#174 from modocache/sr-1901-remove-workarounds swift-integration-tests c95c832 Merge pull request swiftlang#12 from abertelrud/fix-swift-package-init-lib-test swift-xcode-playground-support 4b40c34 Merge pull request swiftlang#10 from apple/stdlib-unittest-expect-nil swiftpm 65403f5 [ConventionTests] Collect all the diagnostics from PackageBuilder
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Remove invalid versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in SR-187,
Int(_:radix:)(and analogous functions on other integer types) used to unintentionally accept the following cases:Where as the docs specify it returns
nilfor anything other than[-+]?[0-9a-zA-Z].Passes
build-script -R -tsuccessfully.