-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[embedded] Port Swift.String to embedded Swift #70446
Conversation
92d592a
to
db981ab
Compare
db981ab
to
ea40683
Compare
ef6cb70
to
3c76677
Compare
3c76677
to
7ae20b7
Compare
@swift-ci please test |
…ead, add armv7 test
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to follow up on this to introduce a flag for the data tables inclusion as well as a flag to turn off strings entirely (due to code-size impact).
These improvements can be done post-facto imho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EmbeddedRuntime changes look good to me.
It looks amazing! 🥳 |
@swift-ci please build macOS toolchain |
@swift-ci Please Build Toolchain macOS Platform |
If you're using Embedded Swift to reduce final binary size, using
After a PR is merged, development snapshots are tagged nightly on a condition that all tests are passing on all platforms, which may not always be the case. Last time this happened on 1st of May, for a new snapshot to be created again all of the failing toolchain snapshots have to be fixed on all officially supported platforms. |
@swift-ci please test |
@swift-ci please test |
…ocations on 32-bit systems)
@swift-ci please test |
@swift-ci Please Build Toolchain macOS Platform |
@swift-ci please test |
This is a port of String, as it is, to Embedded Swift. While a lot of embedded developers might not want Unicode-compliant, dynamically allocated strings in their programs, some might and so let's enable that, and explore "other" strings separately.
Notably, this enables:
Notably, this does not enable:
String(describing: ...)
andString(reflecting: ...)
of arbitrary typesThis PR roughly contains this:
validateUTF8
.