You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 17, 2021. It is now read-only.
The phpdoc block in fromPath method is suggesting Swift_Mime_Attachment as a return type, while the method is returning an instance of self.
This is a problem when using a function with type-hinted parameter or return type.
Example:
This PR was merged into the 6.2-dev branch.
Discussion
----------
fix fromPath return type. See issue #1164
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| Doc update? | no
| BC breaks? | no
| Deprecations? | no
| Fixed tickets | #1164
| License | MIT
Commits
-------
e1dd436 fix fromPath return type. See issue #1164
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The phpdoc block in fromPath method is suggesting
Swift_Mime_Attachment
as a return type, while the method is returning an instance ofself
.This is a problem when using a function with type-hinted parameter or return type.
Example:
This is highlighted as error in IDE (e.g. phpStorm), because
$attachment
type isSwift_Mime_Attachment
, while function is acceptingSwift_Attachment
.Solution is trivial, I can provide a PR.
The text was updated successfully, but these errors were encountered: