Skip to content
This repository has been archived by the owner on Nov 17, 2021. It is now read-only.

Add support for Opendkim on Travis #528

Closed
wants to merge 3 commits into from
Closed

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Sep 20, 2014

Unfortunately, adding the opendkim PHP extension makes PHP crash when running Composer.

@xdecock Can you have a look at it as it makes support for opendkim unusable for anyone using Composer?

@xdecock
Copy link
Member

xdecock commented Sep 20, 2014

I'll check to fix the extension, but the full api seems to have evolved

Going as fast as possible

PS : i'll do another merge request regarding cloning of signers (which are
not cloned currently)
Le 20 sept. 2014 08:55, "Fabien Potencier" notifications@github.com a
écrit :

Unfortunately, adding the opendkim PHP extension makes PHP crash when
running Composer.

@xdecock https://github.com/xdecock Can you have a look at it as it

makes support for opendkim unusable for anyone using Composer?

You can merge this Pull Request by running

git pull https://github.com/swiftmailer/swiftmailer opndkim-on-travis

Or view, comment on, or merge it at:

#528
Commit Summary

  • refactored .travis file
  • added support for opendkim

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#528.

@xdecock
Copy link
Member

xdecock commented Sep 20, 2014

Ok, should be solved, a change in API, it's even strange it even worked,

I've added a composer.json file in the repos not sure it helps

@fabpot
Copy link
Member Author

fabpot commented Sep 20, 2014

@xdecock It's not compiling anymore: see https://travis-ci.org/swiftmailer/swiftmailer/jobs/35799357 for instance

@xdecock
Copy link
Member

xdecock commented Sep 20, 2014

Any way to find the version on libopendkim installed on travis?

@fabpot
Copy link
Member Author

fabpot commented Sep 20, 2014

From the output:

Unpacking libopendkim-dev (from .../libopendkim-dev_2.6.8-0ubuntu1.0.1_amd64.deb)

@xdecock
Copy link
Member

xdecock commented Sep 20, 2014

OK, the api break was between 2.9 and 2.6 not 2.0, correction is pushed, compiles on 12.04, the extension test works without issues (no segfaults)

@fabpot
Copy link
Member Author

fabpot commented Sep 20, 2014

It compiles now but there is still a segfault.

@xdecock
Copy link
Member

xdecock commented Sep 20, 2014

I'm unable to reproduce the segfault on a 12.04 here, (i only have 64 bit machines however, not sure about travis)

- composer self-update
- composer update --no-interaction --prefer-source
- sh -c 'if [ "$TRAVIS_PHP_VERSION" != "hhvm-nightly" ]; then sudo apt-get install libopendkim-dev && cd /tmp/ && git clone https://github.com/xdecock/php-opendkim && cd /tmp/php-opendkim && phpize && ./configure && make && make install; fi;'
- sh -c 'if [ "$TRAVIS_PHP_VERSION" != "hhvm-nightly" ]; then echo "extension = opendkim.so" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini; fi;'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this line is moved to before_script does it works? (not the best solution but i can't understand what's going on

- gem install mailcatcher

install:
- COMPOSER_ROOT_VERSION=dev-master composer --prefer-source install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to set COMPOSER_ROOT_VERSION (it is needed only when you have a circular dependency involving the root package. So symfony was using it because some of its dev dependencies depend on Symfony components too, and ICU was creating issues too with a circular dependency. There is nothing like that in swiftmailer)

@fabpot fabpot closed this Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants