Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebIDLToSwift: Generate single file to make output filenames predictable #19

Merged
merged 6 commits into from
May 2, 2022

Conversation

kateinoigakukun
Copy link
Member

No description provided.

Copy link
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little nit but otherwise LGTM!

@@ -9,14 +9,18 @@ func main() {
let idl = try IDLParser.parseIDL()
print("Removing old files...")
try IDLBuilder.cleanOutputFolder()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a Sources/DOMKit/Generated.swift file and then move all the Sources/DOMKit/ECMAScript/* files to the root of DOMKit. That would mean there would be no need to delete anything anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of DOMKit/ECMAScript/* should be moved to JavaScriptKit because they are independent of DOM spec.
But for now, I want to move them to a separate ECMAScript module in this repo to be used in multiple modules after split-out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I definitely think there’s a place for a third module (or in JSKit? idk) that exposes the full ECMAScript APIs that are not part of the DOM.

MaxDesiatov added a commit that referenced this pull request May 2, 2022
This shouldn't conflict much with #19, as it generates a single `console.swift` file.

Co-authored-by: Jed Fox <git@jedfox.com>
@MaxDesiatov MaxDesiatov changed the title WebIDLToSwift: Generate into a single file to make the output filenames predictable WebIDLToSwift: Generate single file to make output filenames predictable May 2, 2022
@MaxDesiatov
Copy link
Contributor

Sorry about the conflicts, it's ready for merging now 🙂

@kateinoigakukun kateinoigakukun merged commit 271ef41 into main May 2, 2022
@kateinoigakukun kateinoigakukun deleted the katei/generate-single-file branch May 2, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants