-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebIDLToSwift: Generate single file to make output filenames predictable #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little nit but otherwise LGTM!
Sources/WebIDLToSwift/main.swift
Outdated
@@ -9,14 +9,18 @@ func main() { | |||
let idl = try IDLParser.parseIDL() | |||
print("Removing old files...") | |||
try IDLBuilder.cleanOutputFolder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have a Sources/DOMKit/Generated.swift
file and then move all the Sources/DOMKit/ECMAScript/*
files to the root of DOMKit
. That would mean there would be no need to delete anything anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most of DOMKit/ECMAScript/*
should be moved to JavaScriptKit because they are independent of DOM spec.
But for now, I want to move them to a separate ECMAScript
module in this repo to be used in multiple modules after split-out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I definitely think there’s a place for a third module (or in JSKit? idk) that exposes the full ECMAScript APIs that are not part of the DOM.
Sorry about the conflicts, it's ready for merging now 🙂 |
a2745ed
to
c2bee0a
Compare
No description provided.