Use async/await and actors instead of Combine
#283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonihemi
previously approved these changes
Jan 2, 2022
|
We should remember to add the concurrency warnings to CartonKit. swiftSettings: [
.unsafeFlags([
"-Xfrontend", "-warn-concurrency",
"-Xfrontend", "-enable-actor-data-race-checks",
])
]Probably too early now as SwiftPM, TSC & Vapor types are not yet annotated with Sendable. |
|
Not merging this yet, seeing some problems with the watcher not picking up changes... |
yonihemi
approved these changes
Jan 17, 2022
I've been working with main branch of carton and lately seeing similar issues as well. Not sure if a regression from before but I guess it's not introduced by this PR. I think we can merge and look at the file watcher separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes our codebase smaller by ~80 lines and arguably more readable. Also removes OpenCombine dependency.