Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👨🏻‍🎨 Rework build errors formatting #252

Merged
merged 12 commits into from
Oct 15, 2023
Merged

Conversation

swiftyfinch
Copy link
Owner

Description

I've reworked build error formatting, fixed some issues and added tests.

References

Checklist (I have ...)

  • 🧐 Followed the code style of the rest of the project
  • 📖 Updated the documentation if necessary
  • 👨🏻‍🔧 Added at least one test that validates that my change is working, if appropriate
  • 👮🏻‍♂️ Run make lint and fixed all warnings
  • ✅ Run make test and fixed all tests

❤️ Thanks for contributing to the 🏈 Rugby!

@swiftyfinch swiftyfinch added 🚀 Enhancement New feature or request ⚙️ Engineering Task Technical stuff hacktoberfest Support open source throughout October! tests Usually automated testing labels Oct 15, 2023
@swiftyfinch swiftyfinch self-assigned this Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (c3439cf) 13.89% compared to head (420ffda) 15.98%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   13.89%   15.98%   +2.08%     
==========================================
  Files         154      158       +4     
  Lines        4477     4486       +9     
==========================================
+ Hits          622      717      +95     
+ Misses       3855     3769      -86     
Files Coverage Δ
...rces/RugbyFoundation/Core/Build/BuildManager.swift 0.00% <ø> (ø)
...tion/Core/Build/XcodeBuild/BuildLogFormatter.swift 100.00% <100.00%> (+100.00%) ⬆️
...ion/Core/Build/XcodeBuild/XcodeBuildExecutor.swift 100.00% <100.00%> (+100.00%) ⬆️
...l/Extensions/Swift/String/String+PrefixCount.swift 100.00% <100.00%> (ø)
...rnal/Extensions/Swift/String/String+Removing.swift 100.00% <100.00%> (ø)
...ns/Swift/String/String+UppercasedFirstLetter.swift 100.00% <100.00%> (ø)
...s/RugbyFoundation/Vault/Commands/Vault+Build.swift 0.00% <0.00%> (ø)
...es/RugbyFoundation/Core/Common/ShellExecuter.swift 0.00% <0.00%> (ø)
...ources/RugbyFoundation/Core/Build/BuildError.swift 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swiftyfinch swiftyfinch merged commit 4f79852 into main Oct 15, 2023
9 checks passed
@swiftyfinch swiftyfinch deleted the build-errors branch October 15, 2023 18:12
@swiftyfinch swiftyfinch linked an issue Oct 15, 2023 that may be closed by this pull request
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Engineering Task Technical stuff 🚀 Enhancement New feature or request hacktoberfest Support open source throughout October! tests Usually automated testing
Projects
None yet
1 participant