Disable -py3-stable-abi + -threads + -directors

swig · Nov 18, 2019 · bd9f159 · bd9f159
1 parent 250b834
commit bd9f159
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/Source/Modules/python.cxx b/Source/Modules/python.cxx
@@ -459,6 +459,14 @@ class PYTHON:public Language {
       SWIG_exit(EXIT_FAILURE);
     }
 
+    if (py3_stable_abi && threads && directorsEnabled()) {
+      // directors + threads uses PyThread_* APIs, which are not exported from python3.dll on Windows,
+      // despite nominally being a part of the stable ABI. 
+      // To prevent confusing users with linker errors, we disable this combination.  
+      Printf(stderr, "-py3-stable-abi, -threads and -directors options are not compatible.\n");
+      SWIG_exit(EXIT_FAILURE);
+    }
+
     if (py3_stable_abi && fastproxy) {
       Printf(stderr, "-py3-stable-abi and -fastproxy options are not compatible.  Disabling -fastproxy.\n");
       fastproxy = 0;