Use PyObject_GC_UnTrack for python >= 3.6 #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsfulton
reviewed
Jul 16, 2019
The _PyObject_GC_UNTRACK[1] macro got deprecated in 3.6 and finally removed in 3.8. Therefore use PyObject_GC_UnTrack instead. [1] https://docs.python.org/3/c-api/gcsupport.html#c._PyObject_GC_UNTRACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PyObject_GC_UnTrack macro got deprecated in 3.6 and finally removed in 3.8. Thus for all python versions >= 3.6 instead used
PyObject_GC_UnTrack.Closes issue #1586