Fix directed method returning class without default ctor #2645
+57
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wrote in the issue:
However the CI logs have expired so I've rebased and force-pushed the branch (I cherry-picked and merged the comment fix commit a while ago). |
ojwb
force-pushed
the
director-return-no-default-ctor
branch
from
97036d3
to
713b78f
Compare
|
Sorry, I added the swig-4.2 milestone because I thought this was ready for review, but with the CI testing showing failures, I got that wrong, so removing. |
|
It'd be nice to resolve and I'll try to have another poke, but indeed doesn't need to be a blocker for 4.2.0. |
This wasn't working for Go, Ocaml, Octave, PHP, Python or Ruby. Fixes swig#1145
ojwb
force-pushed
the
director-return-no-default-ctor
branch
from
713b78f
to
7424c0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.