Fix bugs in Octave module loading #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lValue() - this introduces a memory leak, which becomes significant for large modules (many global variables) and many module re-loadings (e.g. during a long-running script) - the original motivation was to prevent double-frees on exit, but this problem appears to have been fixed by the _Exit() hack in later commits, and in any case is an issue only for Octave ~3.2, so it should be safe to remove; tested by running Octave examples/test suite with Debian 3.2.4 and built-from-source 3.2.4, 3.4.3, and 3.6.3
- once installed, Octave functions can never really be uninstalled (clear -f doesn't prevent the function being called again), so it makes no sense to install functions more than once - this can lead to a significant speed-up of module loading times, up to a factor of 10 for a large module loaded multiple times
wsfulton
pushed a commit
that referenced
this pull request
Feb 14, 2017
wsfulton
pushed a commit
that referenced
this pull request
Feb 14, 2017
wsfulton
pushed a commit
that referenced
this pull request
Feb 14, 2017
wsfulton
pushed a commit
that referenced
this pull request
Feb 14, 2017
This reverts commit e4e2802.
wsfulton
pushed a commit
that referenced
this pull request
Feb 14, 2017
This reverts commit 7881316.
wsfulton
pushed a commit
that referenced
this pull request
Feb 14, 2017
wsfulton
pushed a commit
that referenced
this pull request
Feb 14, 2017
This reverts commit df33180.
wsfulton
pushed a commit
that referenced
this pull request
Feb 14, 2017
wsfulton
pushed a commit
that referenced
this pull request
Feb 14, 2017
This adds a second file SwigMem.m that like SwigRef.m is common to all modules. You might need to update your build instructions accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the git commit messages for further details.
Patches was tested by running Octave examples/test suite for versions 3.2.4, 3.4.3, 3.6.3