Update tsconfig and package for Angular 13 #1727
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsconfig.lib.prod.json: add "compilationMode": "partial" (for angular 13) box.component.ts: delete cloneDeep and use simple code to clone LineCoordinates (array of 4 Vector2D)
package.json (in projets): add @types/d3 to peerDependencies
|
Any possible ETA on this PR being merged? |
|
Will this be merged at all? I'm getting sad that this library isn't getting the attention that it needs. |
9 tasks
9 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Other... Please describe:
Update tsconfig for Angular 13
Suppress cloneDeep in lib/box-chart/box.component.ts (fix 19.1 triggers angular import warning: swimlane-ngx-charts.js depends on 'clone-deep'. CommonJS or AMD dependencies can cause optimization bailouts. #1688 for Angular 13)
Add @types/d3 in peerDependencies in projects\swimlane\ngx-charts\package.json
(fix error TS7016: Could not find a declaration file for module 'd3-scale'. Versions 19.1.0 through 20.1.2 #1686 for Angular 13)
What is the current behavior? (You can also link to an open issue here)
#1688 when compile an application in angular 13 with ngx-charts
What is the new behavior?
No warning with this pr.
Suppress cloneDeep in lib/box-chart/box.component.ts and use new method to clone a LineCoordinates
(array of 4 Vector2D)
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: