Update tsconfig and package for Angular 14.x and 15.x, update d3 packages, suppress rfdc #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsconfig.lib.json: lib: change enableIvy in compilationMode
…er packages package.json: demo: delete @angular/flex-layout (not used and deprecated)
…anrideshark in pr swimlane#1763 (with rfdc, there is the same message like clone-deep: CommonJS or AMD dependencies can cause optimization bailouts) ng-package.json: remove rfdc
|
this comment is to express that I would like this merged ASAP. Thanks! |
|
When can this be merged @maintainers? |
|
Any update on this @marjan-georgiev @Hypercubed @haeminn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Other... Please describe:
Update tsconfig for Angular 14.x (and 15.x) . Target is es2020, see: https://angular.io/guide/typescript-configuration#target
Update package.json for angular 14.x (and 15.x)
Update d3 packages (fix Update d3-color to resolve vulnerability SNYK-JS-D3COLOR-1076592 #1845,
"d3-color": "^2.0.0"is causing high Dependency alert #1809 and High Vulnerability in d3-color < v3.1.0 #1799)Add @types/d3 in peerDependencies in projects\swimlane\ngx-charts\package.json (fix Types of d3-shape missing #1826 and error TS7016: Could not find a declaration file for module 'd3-scale'. Versions 19.1.0 through 20.1.2 #1686)
Suprress rfdc in boxchart. Package rfdc used in Replace deep clone #1771 generates the message : CommonJS or AMD dependencies can cause optimization bailouts. My previous code in pr Update tsconfig and package for Angular 13 #1727 has no success. In this pr, code proposed by @bryanrideshark in pr Remove clone-deep dependency #1763 replace cloneDeep in box.component.ts
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Demo for 20.3.0 here:
https//www.inway.fr/ngx-charts