Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow angular 15 peer dependencies #486

Merged
merged 1 commit into from
Feb 7, 2023
Merged

allow angular 15 peer dependencies #486

merged 1 commit into from
Feb 7, 2023

Conversation

abiiiiiii
Copy link
Contributor

@abiiiiiii abiiiiiii commented Jan 26, 2023

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
#481

What is the new behavior?
allow angular 15 peer dependencies

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

@abiiiiiii
Copy link
Contributor Author

@marjan-georgiev I tested the lib with Angular 15 (npm i --force), it works without any issues.

@jurvi
Copy link

jurvi commented Feb 7, 2023

I have also been using the latest version in Angular 15 application for 2 months without any issues (other than having to do npm install --force).

Would be nice to not have to use --force though. :)

@marjan-georgiev

@marjan-georgiev marjan-georgiev merged commit 430af54 into swimlane:master Feb 7, 2023
@jurvi jurvi mentioned this pull request Feb 7, 2023
@tzachs
Copy link

tzachs commented Feb 7, 2023

Sorry if I'm missing something but is there a new package about to be released? I'm guessing 8.0.4?

@tzachs
Copy link

tzachs commented Feb 11, 2023

@marjan-georgiev thank you for merging this fix but the current package 8.0.3 does not hold the fix for it, is there a new version planned to be released soon?

Thanks in advanced

@nawnitraman
Copy link

Regarding the availability of the fix, any update please ?

@abiiiiiii
Copy link
Contributor Author

#492

@moorthyptm
Copy link

We have few other issues in angular 15 with @swimlane/ngx-graph": "^8.0.3

image

image

@moorthyptm moorthyptm mentioned this pull request Apr 17, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants