Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update angular to 17 #543

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kr0san89
Copy link
Contributor

@Kr0san89 Kr0san89 commented Mar 5, 2024

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?
new angular version

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
only angular 17
the documentation system has some issues (need updates there too)

Other information:

@DeepakGMTT
Copy link

DeepakGMTT commented Jun 24, 2024

hi @marjan-georgiev i'm using this package for my project can we please priority this PR. Can we have the time line when this PR will be merged?

@mayurmuley1412
Copy link

hi @marjan-georgiev i'm using this package for my project can we please priority this PR. Can we have the time line when this PR will be merged?

I am also waiting for the merge and release. @Kr0san89 Can you check conflicts and merge this PR since its approved.

@Kr0san89
Copy link
Contributor Author

hi @marjan-georgiev i'm using this package for my project can we please priority this PR. Can we have the time line when this PR will be merged?

I am also waiting for the merge and release. @Kr0san89 Can you check conflicts and merge this PR since its approved.

Sadly i can not the approvement has to come from a person with "write access" which is not the case yet. It is not even clear if they want to merge this PR at some stage. As i have another PR open for over a year #513 i got a bit more carefull how i invest my time here.

If there is a comment from someone who can merge that they will i would do it, but until then i'll wait.

But this PR will not bring you much benefit other than "smaller bundle"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants