Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix base class in Snowflake AI #1207

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix base class in Snowflake AI #1207

merged 1 commit into from
Feb 20, 2024

Conversation

sid-swirl
Copy link
Contributor

Branching Reminders

X For core code changes, create a branch off develop

  • For product documentation changes, create a branch off main
  • Always name your branch in a way that clearly describes your proposed changes

Description

Switch SnowflakeAI from DBConnector to Connector base class
The DBConnector was failing in construct_query()

Related Issue(s)

DS-1706

Testing and Validation

I used a stub to test, connectivity errors may still occur

Type of Change

  • Bug fix or other non-breaking change that addresses an issue
  • New Feature / Enhancement (non-breaking change that add or improves functionality)
  • New Feature (breaking change that is not backwards compatible and/or alters current functionality)
  • Documentation (change to product documentation or README.md only)

@dnicodemus dnicodemus merged commit f2f1ba0 into develop Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnicodemus dnicodemus dnicodemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sid-swirl @dnicodemus