make it possible to import input's events from html5 menus #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rodneyrehm could you please comment on this issue? accept || reject? |
|
@rodneyrehm how do you suppose to not use name there? |
|
It's a function. it needs a name. "cb" is not a name. |
|
@jbinary Hi. I didn't mean to "steal" your PR. I thought you had no interest in this issue anymore. Feel free to commit changes yourself. I will close my PR afterwards. I think Rodney used a figurative speech saying "... or none at all" |
|
@rodneyrehm but your suggestion is not a name too, what does it mean, create trigger? but cb to me is enough for this situation. @jzelenkov ah, I don't care, I had no time to reply so thank you for finalizing that. But I really think that the "createTriggerEvent" name means nothing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.