This repository has been archived by the owner on Feb 7, 2019. It is now read-only.
Filter on related objects #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e) filter When this test was added, this returned a Player object: - Player.objects.as_of(t1).get(team=team_current, name='p1.v1') (note: team_current is not the version of the team associated with this player at t1) But these did not: - Player.objects.as_of(t1).get(team=team_at_t1, name='p1.v1') (note: team_at_t1 *is* the version of the team associated with this player at t1) - Player.objects.as_of(t1).get(team=team_at_t2, name='p1.v1') (note: team_at_t2 is not the version of the team associated with this player at t1) Providing an object in the filter is standard practice, and it seems like it would be nice to allow this to work, without having to write something like: - Player.objects.as_of(t1).get(team__identity=team_at_tx.identity, name='p1.v1') Although the foreign key actually points to the id column of the foreign object, when we ask for objects at a point in time, we need to look for related objects that a) have the identity == foreign key value, and b) are valid at the given point in time.
…to match an object at a given time
|
Also, see the long commit message for brki@be92df9 , which provides some explanation. |
|
Hey @brki, I agree! Thanks for implementing this! |
maennel
added a commit
that referenced
this pull request
Jan 6, 2016
Filter on related versionable objects using objects as values for lookups, which is the Django standard behaviour.
|
Thanks @brki ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow using object for filtering, clarify behaviour in docs, adjusted one existing test to use explicit ids.